Refactor stridingMemcpyKernel to be unroll friendly#65
Open
Artem-B wants to merge 1 commit intoNVIDIA:mainfrom
Open
Refactor stridingMemcpyKernel to be unroll friendly#65Artem-B wants to merge 1 commit intoNVIDIA:mainfrom
Artem-B wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
While loop over incrementing pointer is harder for compiler to analyze. Switching to directly indexed pointer accesses gives compiler more flexibility over unrolling the loop. Also, work around clang-related issue which results in slow code when aggregates are swapped via a temporary variable. Copying uint4 element-wise avoids the problem, and works fine with NVCC.
Author
|
Comparison between clang/nvcc old/new kernel: https://godbolt.org/z/onojWhr7a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While loop over incrementing pointer is harder for compiler to analyze. Switching to directly indexed pointer accesses gives compiler more flexibility over unrolling the loop.
Also, work around clang-related issue which results in slow code when aggregates are swapped via a temporary variable. Copying uint4 element-wise avoids the problem, and works fine with NVCC.