add workflow to add list of all images in gpu-operator release as asset to release#2367
Open
rahulait wants to merge 2 commits intoNVIDIA:mainfrom
Open
add workflow to add list of all images in gpu-operator release as asset to release#2367rahulait wants to merge 2 commits intoNVIDIA:mainfrom
rahulait wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Rahul Sharma <rahulsharm@nvidia.com>
rahulait
requested review from
cdesiniotis,
karthikvetrivel,
rajathagasthya,
shivamerla and
tariq1890
as code owners
rahulait
changed the title
rahulait
changed the title
karthikvetrivel
approved these changes
Apr 24, 2026
tariq1890
reviewed
Apr 24, 2026
| --output "${ARTIFACT_NAME}" | ||
| echo "artifact_name=${ARTIFACT_NAME}" >> "${GITHUB_OUTPUT}" | ||
| - name: Upload image list artifact | ||
| uses: actions/upload-artifact@v4 |
Contributor
There was a problem hiding this comment.
Suggested change
| uses: actions/upload-artifact@v4 | |
| uses: actions/upload-artifact@v7 |
| with: | ||
| ref: ${{ github.event.release.tag_name }} | ||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 |
Contributor
There was a problem hiding this comment.
Suggested change
| uses: actions/setup-python@v5 | |
| uses: actions/setup-python@v6 |
| sed '/^--/d' | \ | ||
| ./gpuop-cfg validate clusterpolicy --input="-" | ||
|
|
||
| # Generate a list of all container images required to run the GPU Operator. |
Contributor
There was a problem hiding this comment.
Suggested change
| # Generate a list of all container images required to run the GPU Operator. | |
| # Generate a list of all container images that could be deployed by the GPU Operator. |
| - uses: actions/checkout@v6 | ||
| name: Check out code | ||
| - name: Download image list artifact | ||
| uses: actions/download-artifact@v4 |
Contributor
There was a problem hiding this comment.
Suggested change
| uses: actions/download-artifact@v4 | |
| uses: actions/download-artifact@v8 |
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Generate a complete list of container images required to run the GPU Operator. |
Contributor
There was a problem hiding this comment.
Suggested change
| """Generate a complete list of container images required to run the GPU Operator. | |
| """Generate a complete list of container images that could be pulled and deployed the GPU Operator. |
| ) | ||
|
|
||
| # k8s-driver-manager sidecar | ||
| dm = driver.get("manager", {}) |
Contributor
There was a problem hiding this comment.
nit: instead of abbreviations, i prefer using the expanded names as variables here.
| """ | ||
| images: set[str] = set() | ||
|
|
||
| def add(repo: str, img: str, ver: str | None) -> None: |
Contributor
There was a problem hiding this comment.
let's choose a better name here please. add is too short and non-specific
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1266
See sample run output from a forked repo where this GHA was run: https://github.com/rahulait/gpu-operator/releases/tag/v26.3.1
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing