#1421 Add port annotation for prometheus#1422
Closed
DominicWatson wants to merge 1 commit intoNVIDIA:mainfrom
Closed
#1421 Add port annotation for prometheus#1422DominicWatson wants to merge 1 commit intoNVIDIA:mainfrom
DominicWatson wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
metrics. This should allow support for more hosting scenarios where Prometheus may be trying a default port, e.g. 9100, rather than trying the ports defined on the service automatically.
DominicWatson
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
Contributor
|
May need/want to also add this to DCGM Exporter directly. |
Contributor
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
github-actions
Bot
added
the
lifecycle/stale
rahulait
removed
the
lifecycle/stale
Contributor
|
Adding custom annotations to dcgm-exporter daemonset has been done in #2271. Closing this PR. Please feel free to open an issue with your requirements if that doesn't help you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to issue #1421
Add port annotation for Prometheus to use when scraping for metrics. This should allow support for more hosting scenarios where Prometheus may be trying a default port, e.g. 9100, rather than trying the ports defined on the service automatically.