feat(pathfinder): support "cuda"/"nvml" driver libs and reject unsupported libnames #1602
+209
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
cpcloud
force-pushed
the
driver-libs-and-validation
branch
from
182be13 to
058f824
Compare
…orted libnames
Add support for loading NVIDIA driver libraries ("cuda", "nvml") via
load_nvidia_dynamic_lib(). These are part of the display driver (not the
CTK) and use a simplified system-search-only path, skipping site-packages,
conda, CUDA_HOME, and canary probe steps.
Also reject unrecognized libnames with a ValueError instead of silently
falling through to system search, which could produce surprising results
for unsupported libs like "cupti".
Closes NVIDIA#1288, closes NVIDIA#1564.
Co-authored-by: Cursor <cursoragent@cursor.com>
cpcloud
force-pushed
the
driver-libs-and-validation
branch
from
058f824 to
902a7f5
Compare
Contributor
Author
|
/ok to test |
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit support in cuda.pathfinder for loading NVIDIA driver libraries ("cuda", "nvml") via a system-search-only path, and hard-fails on unknown library names to avoid surprising implicit loads.
Changes:
- Add platform-specific driver library name mappings (
libcuda.so.1/nvcuda.dll,libnvidia-ml.so.1/nvml.dll) to the supported-lib registries. - Introduce a dedicated driver-only loading path (skip wheel/conda/CUDA_HOME/canary) and validate
libnameagainst a platform-aware supported set. - Expand tests to cover driver lib dispatch behavior and unsupported-libname validation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
cuda_pathfinder/cuda/pathfinder/_dynamic_libs/supported_nvidia_libs.py |
Adds driver-library mappings and folds them into the platform registries. |
cuda_pathfinder/cuda/pathfinder/_dynamic_libs/load_nvidia_dynamic_lib.py |
Adds supported-name validation and a driver-only load path that bypasses the CTK cascade. |
cuda_pathfinder/tests/test_driver_lib_loading.py |
New targeted unit tests for driver-only behavior and dispatch rules. |
cuda_pathfinder/tests/test_load_nvidia_dynamic_lib.py |
Updates tests to use mocker and adds unsupported-libname validation tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cuda_pathfinder/cuda/pathfinder/_dynamic_libs/load_nvidia_dynamic_lib.py
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
/ok to test |
rparolin
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
load_nvidia_dynamic_lib()"cuda","nvml"#1288: Add support forload_nvidia_dynamic_lib("cuda")andload_nvidia_dynamic_lib("nvml"). These are NVIDIA driver libraries (not CTK) with non-standard naming (libcuda.so.1/nvcuda.dll,libnvidia-ml.so.1/nvml.dll). They use a simplified system-search-only path, skipping site-packages, conda, CUDA_HOME, and canary probe.ValueErrorinstead of silently falling through to system search. The error message includes the full list of supported names for discoverability.Breaking change
load_nvidia_dynamic_lib()now raisesValueErrorfor unrecognized libnames. Any downstream code passing names like"cupti"that happened to work via system search will break. Adding CUPTI as a supported lib (#1572) before the next release would restore that path through the proper search cascade.Changes
supported_nvidia_libs.py— newSUPPORTED_LINUX_SONAMES_DRIVER/SUPPORTED_WINDOWS_DLLS_DRIVERdictsload_nvidia_dynamic_lib.py—_DRIVER_ONLY_LIBNAMES,_load_driver_lib_no_cache(),_ALL_SUPPORTED_LIBNAMESvalidation, updated docstringtests/test_driver_lib_loading.py— 10 new tests for driver lib flowtests/test_load_nvidia_dynamic_lib.py— 2 new tests for validation, migrated tomockerCloses #1288, closes #1564.
Made with Cursor