-
Notifications
You must be signed in to change notification settings - Fork 245
[WIP] Skip tests using managed memory if CU_DEVICE_ATTRIBUTE_CONCURRENT_MANAGED_ACCESS == 0
#1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
The temporary commit bddca29 is a trick to identify the tests we need to skip. Full build and test logs (internal access only); |
Treat missing cuMemAllocManaged as disabled access and gate managed-memory test paths in cuda_core and cuda_bindings to avoid false failures. Co-authored-by: Cursor <cursoragent@cursor.com>
…_core/tests/test_launcher.py::test_launch_invalid_values
|
I backed out the band-aid change made with PR #1567 (commit 85f76f5) because it could later mask if we miss skips. Cursor-generated skips (commit b9f8452) pass local testing, with the Running the CI to see if we still have tests that depend on |
|
/ok to test |
|
Move the managed-memory skip logic into cuda_python_test_helpers and point bindings/core tests at the shared module, with path bootstrapping to prefer in-repo helpers. This avoids relying on bindings test helpers that are absent in 12.9.x wheels. Co-authored-by: Cursor <cursoragent@cursor.com>
71f271a to
a48565f
Compare
Closes nvbug 5815123
Background: #1539
This PR will have two stages: 1. identify the tests we need to skip, 2. add the skips