rtx: Add more firefly filters#309
Merged
Merged
Conversation
parseANARIObjectInfo dropped the declared default for ANARI_STRING params (parseValue returns empty) then forced the first listed value, so every string-enum object param ignored its metadata default. The renderer UI showed fireflyFilterMode=none even though the device declares tonemap. Read the default string straight from the metadata and select it when it names one of the enum values.
Better keep image dynamic compared to `tonemap`. `tonemap` is still the default, so default rendering is unchanged. The old `fireflyFilter` / `tonemap` bools are gone -- pre-1.0, no back-compat.
New per-pixel firefly filter: an upper-trimmed mean (robust statistics) that picks which samples to drop with a Grubbs/ESD outlier test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides the existing default
tonemap, this PR addsclampandtrimfiltering modes.tonemaptends to dim bright lights too much for the sake of stability at low sample count.The new
clampandtrimprovide new filtering trading memory and performances for quality.Below are
unfiltered(left),tonemap(middle),trim(right) at 32 spp.