fix(packaging): use gateway TOML config in packages#1415
Draft
drew wants to merge 1 commit into
Draft
Conversation
drew
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
TaylorMutch
previously approved these changes
May 15, 2026
|
🌿 Preview your docs: https://nvidia-preview-pr-1415.docs.buildwithfern.com/openshell |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
drew
force-pushed
the
use-toml-in-install
branch
3 times, most recently
from
a972bad to
a5903b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move Homebrew, deb, and snap gateway package defaults into
gateway.tomlnow that the gateway supports TOML configuration. New installs create the canonical packagegateway.tomldirectly and no longer create a packagegateway.env; existing env files are still read so gatewayOPENSHELL_*variables continue to take precedence at launch.Related Issue
N/A
Changes
deploy/common/init-gateway-config.shfor deb, snap, and generated Homebrew formulas.--drivers,OPENSHELL_DRIVERS, or edited TOML, otherwise gateway auto-detection applies.#{var}/openshell/gateway.toml, and keep reading existinggateway.envfiles before launching.%S/openshell/gateway/config.toml, and preserve the systemdEnvironmentFilecompatibility path.$SNAP_COMMON/gateway.tomlthrough the shared helper while still honoring launch env such asOPENSHELL_GATEWAY_CONFIGandOPENSHELL_DB_URL.Testing
mise run pre-commitpassesuv run pytest python/openshell/release_formula_test.pysh -n deploy/common/init-gateway-config.shsh -n deploy/snap/bin/openshell-gateway-wrapperbash -n tasks/scripts/package-deb.shbash -n tasks/scripts/package-snap.shsystemd-analyze --user verifynot run;systemd-analyzeis not installed on this hostChecklist