fix(sandbox): set HOME to match target user after privilege drop#1324
Open
Arnonrgo wants to merge 1 commit into
Open
fix(sandbox): set HOME to match target user after privilege drop#1324Arnonrgo wants to merge 1 commit into
Arnonrgo wants to merge 1 commit into
Conversation
When openshell-sandbox runs as root in a container (runAsUser: 0) and drops privileges to the sandbox user, HOME remains /root. Applications that look for config at $HOME fail to find files baked into the sandbox user's home directory. Resolve the target user from the policy before pre_exec and set HOME on the child command so the exec'd process inherits the correct home directory from /etc/passwd.
|
Thank you for your interest in contributing to OpenShell, @Arnonrgo. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
All contributors have signed the DCO ✍️ ✅ |
Contributor
Author
|
I have read the DCO document and I hereby sign the DCO. |
Contributor
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
set_home_for_target_user()function that resolves the target user's home from /etc/passwdspawn_implpaths afterinject_provider_envTesting
cargo check -p openshell-sandboxpasses