feat(db) resource version cas#1292
Open
derekwaynecarr wants to merge 1 commit into
Open
Conversation
derekwaynecarr
requested review from
a team,
maxamillion and
mrunalp
as code owners
derekwaynecarr
changed the title
derekwaynecarr
force-pushed
the
feat/db-resource-version-cas
branch
from
30e8540 to
46c93c3
Compare
johntmyers
reviewed
May 12, 2026
johntmyers
reviewed
May 12, 2026
johntmyers
reviewed
May 12, 2026
derekwaynecarr
force-pushed
the
feat/db-resource-version-cas
branch
from
46c93c3 to
4931e83
Compare
Collaborator
Author
|
@johntmyers ptal. updated per prior feedback, also updated all proto paths that required CAS enablement. the recently merged draft chunk work is not covered right now, i would like to leave that as a follow-on. |
johntmyers
reviewed
May 14, 2026
johntmyers
reviewed
May 14, 2026
johntmyers
reviewed
May 14, 2026
derekwaynecarr
force-pushed
the
feat/db-resource-version-cas
branch
from
4931e83 to
4456536
Compare
Add resource_version-based optimistic concurrency control to the persistence layer. Every write now requires an explicit WriteCondition (MustCreate or MatchResourceVersion), enforced at compile time by gating unconditional put/put_message behind #[cfg(test)]. - Add WriteCondition enum and put_if for conditional writes - Add update_message_cas for atomic read-modify-write operations - Add list_messages/list_messages_with_selector helpers that hydrate resource_version from authoritative DB rows - Convert all production write paths to CAS-aware methods - Gate put/put_message behind #[cfg(test)] to prevent non-CAS writes - Use structured PersistenceError::UniqueViolation matching instead of string matching for duplicate detection - Hydrate resource_version from WriteResult directly on creates, eliminating unnecessary read-after-write round trips Signed-off-by: Derek Carr <decarr@redhat.com>
derekwaynecarr
force-pushed
the
feat/db-resource-version-cas
branch
from
4456536 to
d65c359
Compare
Collaborator
Author
|
All prior comments are resolved.
|
Collaborator
Author
|
/ok to test d65c359 |
Collaborator
Author
|
failure due to flaky test, fix #1417 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Compare-And-Swap (CAS) infrastructure for safe concurrent object mutations
and migrate critical paths to use it. This prevents lost updates in HA
deployments with multiple gateway replicas.
Core infrastructure:
Migrations:
Database migrations backfill existing rows with resource_version = 1.
CAS updates increment atomically: resource_version = resource_version + 1.
gRPC handlers map PersistenceError::Conflict to ABORTED status code
to signal clients to retry with fresh data. Server-side retries use
bounded retry (5 attempts) with fresh reads on each iteration.
Test coverage includes concurrent update scenarios and handler-level
resource_version round-trip tests.
Related Issue
Fixes #1255
Changes
Testing
mise run pre-commitpassesChecklist