feat(gateway): add local-domain service routing#1101
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-1101.docs.buildwithfern.com/openshell |
|
Label |
Collaborator
Author
|
/ok to test bb1ef60 |
1a0edfd to
e35fd16
Compare
e35fd16 to
3b01d18
Compare
TaylorMutch
previously approved these changes
May 12, 2026
Collaborator
TaylorMutch
left a comment
There was a problem hiding this comment.
One comment for my own understanding, otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the first pass of gateway-owned domain routing for sandbox-local HTTP and WebSocket services.
Related Issue
Linear: OS-153
Changes
ExposeServiceAPI plumbing and persistedservice_endpointmetadata for named sandbox endpoints.openshell service expose <sandbox> <service> --target-port <port>to create browser-facing endpoint URLs.<sandbox>--<service>.<cluster>.<suffix>before normal gateway HTTP routes, so sandbox app paths like/authare preserved.Testing
mise run pre-commitpassesTargeted checks run during the spike:
cargo fmt --allcargo check -p openshell-bootstrap -p openshell-server -p openshell-clicargo check -p openshell-clihelm lint deploy/helm/openshellcargo test -p openshell-cli gateway_proxy --libcargo test -p openshell-cli service_url_for_gateway --libcargo test -p openshell-server local_domain --libbash -n tasks/scripts/cluster-deploy-fast.shStill required before merge:
mise run pre-commitmise run testor equivalent CI suiteChecklist