fix(launcher): use afterany dependency for allow_to_fail pipelines#1248
fix(launcher): use afterany dependency for allow_to_fail pipelines#1248yeyu-nvidia wants to merge 1 commit intomainfrom
Conversation
nemo-run's SlurmExecutor defaults to dependency_type="afterok", which cancels all downstream tasks when a predecessor times out or fails. For pipelines with allow_to_fail=True, use "afterany" so subsequent tasks run regardless of predecessor exit status. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ye Yu <yeyu@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded conditional logic in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1248 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 350 350
Lines 40481 40481
=======================================
Hits 31137 31137
Misses 9344 9344
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
SlurmExecutordefaults todependency_type="afterok", which cancels all downstream Slurm tasks when a predecessor times out (TIMEOUT) or failsallow_to_fail=True, this changes the dependency type to"afterany"so subsequent tasks run regardless of predecessor exit statusTest plan
uv run python3 -m pytest tests/ -vintools/launcher/)allow_to_fail: trueand confirm task_1 runs after task_0 times outallow_to_failstill use defaultafterokbehavior🤖 Generated with Claude Code
Summary by CodeRabbit