Drop viser dependency#501
Conversation
|
📝 Docs preview is not auto-deployed for fork PRs. A maintainer with write access to |
📝 WalkthroughWalkthroughThis pull request updates the viser library dependency constraint in two files. The example teleop ROS2 project's pyproject.toml changes from a pinned version Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
4afc4be to
9f1492a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@examples/teleop_ros2/python/pyproject.toml`:
- Around line 16-18: The dependency line currently allows viser>=1.0.0 which
reintroduces yourdfpy (and trimesh) despite the comment; change the version
constraint for the package reference "viser>=1.0.0" to a specific range that
excludes releases that depend on yourdfpy (for example pin to "viser<1.0.0" or
to a known safe release like "viser==0.x.y" or a later safe range if available),
or update the comment to accurately state you intend to allow viser>=1.0.0;
locate and modify the dependency token "viser>=1.0.0" in the pyproject.toml and
ensure the comment above it matches the new constraint.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6ec84a2b-8a61-4a73-a7ca-aa3696849db5
📒 Files selected for processing (2)
examples/teleop_ros2/python/pyproject.tomlsrc/core/python/requirements-grounding.txt
9f1492a to
20f02b6
Compare
This reverts commit 3cad769.
Upstream robotic_grounding (v2d @ 3ae3de92) no longer ships the ViserVisualizer dev tool, so the [grounding] extra no longer needs viser. That lets the teleop_ros2 example drop the viser==0.1.0 pin that existed only to keep newer viser -> yourdfpy -> trimesh[easy] -> embreex out of the aarch64 resolve. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ad46a87 to
428c5e2
Compare
Summary by CodeRabbit