Skip to content

Drop viser dependency#501

Merged
jiwenc-nv merged 2 commits into
NVIDIA:mainfrom
jiwenc-nv:jiwenc/fix-viser-deps
May 11, 2026
Merged

Drop viser dependency#501
jiwenc-nv merged 2 commits into
NVIDIA:mainfrom
jiwenc-nv:jiwenc/fix-viser-deps

Conversation

@jiwenc-nv
Copy link
Copy Markdown
Collaborator

@jiwenc-nv jiwenc-nv commented May 11, 2026

Summary by CodeRabbit

  • Chores
    • Updated viser dependency requirement to version 1.0.0 or higher.

Review Change Stack

@github-actions
Copy link
Copy Markdown
Contributor

📝 Docs preview is not auto-deployed for fork PRs.

A maintainer with write access to NVIDIA/IsaacTeleop can deploy a preview by
commenting /preview-docs on this PR. Once deployed, the preview
will live at:

https://nvidia.github.io/IsaacTeleop/preview/pr-501/

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

📝 Walkthrough

Walkthrough

This pull request updates the viser library dependency constraint in two files. The example teleop ROS2 project's pyproject.toml changes from a pinned version viser==0.1.0 to a minimum version viser>=1.0.0. The same dependency is added to the core grounding runtime requirements file with the same minimum version constraint.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/IsaacTeleop#500: Both PRs modify the same file (src/core/python/requirements-grounding.txt) to add the runtime dependency "viser>=1.0.0", indicating closely related or parallel dependency updates.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'Drop viser dependency' contradicts the actual changes, which update and add viser dependency constraints, not remove them. Update the title to reflect the actual changes, such as 'Relax viser version constraints' or 'Update viser to >=1.0.0', matching the PR objective to 'relax viser version'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jiwenc-nv jiwenc-nv force-pushed the jiwenc/fix-viser-deps branch from 4afc4be to 9f1492a Compare May 11, 2026 11:38
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@examples/teleop_ros2/python/pyproject.toml`:
- Around line 16-18: The dependency line currently allows viser>=1.0.0 which
reintroduces yourdfpy (and trimesh) despite the comment; change the version
constraint for the package reference "viser>=1.0.0" to a specific range that
excludes releases that depend on yourdfpy (for example pin to "viser<1.0.0" or
to a known safe release like "viser==0.x.y" or a later safe range if available),
or update the comment to accurately state you intend to allow viser>=1.0.0;
locate and modify the dependency token "viser>=1.0.0" in the pyproject.toml and
ensure the comment above it matches the new constraint.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6ec84a2b-8a61-4a73-a7ca-aa3696849db5

📥 Commits

Reviewing files that changed from the base of the PR and between 3cad769 and 4afc4be.

📒 Files selected for processing (2)
  • examples/teleop_ros2/python/pyproject.toml
  • src/core/python/requirements-grounding.txt

Comment thread examples/teleop_ros2/python/pyproject.toml Outdated
@jiwenc-nv jiwenc-nv force-pushed the jiwenc/fix-viser-deps branch from 9f1492a to 20f02b6 Compare May 11, 2026 11:51
jiwenc-nv and others added 2 commits May 11, 2026 12:03
Upstream robotic_grounding (v2d @ 3ae3de92) no longer ships the
ViserVisualizer dev tool, so the [grounding] extra no longer needs
viser. That lets the teleop_ros2 example drop the viser==0.1.0 pin
that existed only to keep newer viser -> yourdfpy -> trimesh[easy]
-> embreex out of the aarch64 resolve.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@jiwenc-nv jiwenc-nv force-pushed the jiwenc/fix-viser-deps branch from ad46a87 to 428c5e2 Compare May 11, 2026 12:03
@jiwenc-nv jiwenc-nv changed the title relax viser version Drop viser dependency May 11, 2026
@jiwenc-nv jiwenc-nv requested a review from sgrizan-nv May 11, 2026 12:04
@jiwenc-nv jiwenc-nv enabled auto-merge (rebase) May 11, 2026 12:35
@jiwenc-nv jiwenc-nv disabled auto-merge May 11, 2026 14:26
@jiwenc-nv jiwenc-nv merged commit fe0ee07 into NVIDIA:main May 11, 2026
72 checks passed
@jiwenc-nv jiwenc-nv deleted the jiwenc/fix-viser-deps branch May 11, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants