Prioritize XDev hand tracker sources#483
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR extends Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
|
📝 Docs preview is not auto-deployed for fork PRs. A maintainer with write access to |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/core/live_trackers/cpp/live_hand_tracker_impl.cpp`:
- Around line 316-323: Before calling pfn_create_hand_tracker_ and push_back,
ensure the vector cannot reallocate: call trackers.reserve(trackers.size() + 1)
prior to creating the XrHandTrackerEXT so that if push_back would otherwise
trigger reallocation it won't and the newly-created handle won't be leaked;
apply the same reserve-before-create change for the other identical creation
site (the second XrHandTrackerEXT creation block) that uses session,
create_info, pfn_create_hand_tracker_, and trackers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f16693ef-8f2f-4642-8fc4-49ff1a5bd8a1
📒 Files selected for processing (3)
src/core/live_trackers/cpp/CMakeLists.txtsrc/core/live_trackers/cpp/live_hand_tracker_impl.cppsrc/core/live_trackers/cpp/live_hand_tracker_impl.hpp
97be5f0 to
08c4cc5
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
08c4cc5 to
22e2dcf
Compare
Closes #344
This is a temporary fix until the CloudXR runtime has the right behaviour.
Summary by CodeRabbit
Release Notes