added example of github pushing to s3, using oidc#295
added example of github pushing to s3, using oidc#295dlavender4 wants to merge 5 commits intomainfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
andyblundell
left a comment
andyblundell
left a comment
There was a problem hiding this comment.
Looks really good - needs referencing from somewhere though, not sure there's anywhere suitable yet, maybe we need a new list of handy guides for specific stuff like this?
| 11Error: Process completed with exit code 1. | ||
|
|
||
| Ensure Role: fails when has wrong GitHub Repo name: | ||
| - AWS: edit "GitHubS3DeployRole" Trust Policy. Change GitHub Repo in "token.actions.githubusercontent.com:sub" to something random: "repo:NHSDigitalWRONG/tech-radar:ref:refs/heads/main" |
There was a problem hiding this comment.
Maybe change to RandomOrg/RandomRepo or similar? (To remove reference to radar repo)
| - But took 2min, seemed to be timing out / retrying | ||
|
|
||
| Ensure Role fails when has wrong GitHub Branch name: | ||
| - AWS: edit "GitHubS3DeployRole" Trust Policy. Change GitHub branch in "token.actions.githubusercontent.com:sub" to something random: "repo:NHSDigital/tech-radar:ref:refs/heads/mainWRONG" |
There was a problem hiding this comment.
Maybe change to RandomOrg/RandomRepo or similar? (To remove reference to radar repo)
amaanibn-nasar1-nhs
left a comment
amaanibn-nasar1-nhs
left a comment
There was a problem hiding this comment.
It might be worth noting that I've done some work to create a reusable terraform module that does this. https://github.com/NHSDigital/ee-terraform-modules
3 participants
No description provided.