sonarqube benefits of default rules, and making best practices clearer#211
Open
dlavender4 wants to merge 6 commits intomainfrom
Open
sonarqube benefits of default rules, and making best practices clearer#211dlavender4 wants to merge 6 commits intomainfrom
dlavender4 wants to merge 6 commits intomainfrom
Conversation
dlavender4
requested review from
a team,
andyblundell,
iw-ezequiel and
snehal-vahule
iw-ezequiel
reviewed
Nov 1, 2021
| ## Configuring CI pipeline | ||
|
|
||
| Conditions on New Code: | ||
| Making SonarQube part of a Continuous Integration process is recommended: a build should fail if the code analysis did not satisfy the Quality Gate condition (see [Quality Checks](../quality-checks.md)). |
Contributor
There was a problem hiding this comment.
Perhaps reference dashboards as a very compelling reason to do this?
| New starters won't be. | ||
| New starters won't be. | ||
| You've probably also got used to the fact that code changes take X times longer than they could, because the code is not as maintainable as it could be. | ||
|
|
Contributor
There was a problem hiding this comment.
Or, perhaps you've become comfortable with workarounds that are second nature after executing them so many times, and a crude view provided by an external tool serves as a reminder of potential improvements.
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback from bs-select team.
I've made the best-practices clearer.
I've pointed out the MAIN benefit of using sonar default rules is that they are auto-updated and ongoingly curated by the SonarQube team.
I've trimmed the page down a bit - team thought the rest of the info is available on sonarqube's page anyway - fair point. So have kept this as mostly a best-practices page.