fix atc138 and pyREDi wrappers and remove obsolete x86_64 check in whale#426
Merged
fmckenna merged 4 commits intoNHERI-SimCenter:masterfrom Apr 28, 2026
Merged
fix atc138 and pyREDi wrappers and remove obsolete x86_64 check in whale#426fmckenna merged 4 commits intoNHERI-SimCenter:masterfrom
fmckenna merged 4 commits intoNHERI-SimCenter:masterfrom
Conversation
The registry and wrapper expected `tenantUnitsListPath` (plural) while the frontend emits `tenantUnitListPath`, so sWHALE silently dropped the user-supplied tenant unit list. Renamed the registry id, argparse flag, and args attribute to the singular form.
buildingirreparableOrCollapsed[sample] and DVReplacementDict['Time'][sample] are positional accesses on pandas Series whose index is not a RangeIndex. Since pandas 2.x this triggers a Series.__getitem__ deprecation warning; in a future release integer keys will resolve as labels and these calls will silently return the wrong value. Made the positional intent explicit with .iloc[sample]; behavior is unchanged for current pandas, just deprecation-clean.
whale/main.py raised on any non-x86_64 Python on Darwin, dating from when apps shipped only as x86_64 and the Python interpreter was expected to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.