Skip to content

Fixed typo in required element name#16

Open
drmongrain wants to merge 4 commits intomainfrom
drmongrain-patch-2
Open

Fixed typo in required element name#16
drmongrain wants to merge 4 commits intomainfrom
drmongrain-patch-2

Conversation

@drmongrain
Copy link
Copy Markdown
Collaborator

@drmongrain drmongrain commented Dec 15, 2023

Fixed typo in required element

Removed "mediaLab[a|e]l" as mandatory
Comment thread loggingservice.yaml
- type: object
required:
- sdp
- mediaLabal
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct the typo mediaLabal - mediaLabel

Comment thread loggingservice.yaml
- $ref: '#/components/schemas/LogEvent'
- type: object
required:
- mediaLabel
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not remove required parameter here and in the remaiing places

Updated YAML based on consensus reached on Jan 11 2024 meeting
@drmongrain drmongrain changed the title Update loggingservice.yaml to not make "mediaLabel" mandatory Fixed typo in required element name Jan 25, 2024
Comment thread loggingservice.yaml Outdated
- type: object
required:
- mediaLabel
- mediaLabel
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct indentation pls

Comment thread loggingservice.yaml Outdated
- type: object
required:
- mediaLabel
- mediaLabel
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct indentation pls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants