Conversation
Bump swift-demangling to 0.2.0 to pick up a critical demangling fix. 0.9.0/0.9.1 shipped with swift-demangling pinned below 0.2.0 and should not be used — 0.10.0 replaces them. - Package.swift: swift-demangling from "0.2.0" - Changelogs: rename 0.9.0.md -> 0.10.0.md with supersede notice, drop 0.9.1.md - README: bump install snippet and CLI note to 0.10.0 - Version.swift: bump dev placeholder to 0.10.0-dev
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request bumps the project version to 0.10.0, updates the swift-demangling dependency to 0.2.0 to fix a critical bug, and consolidates release notes. The review identifies a version mismatch for MachOKit between the changelog and the package manifest, and suggests including the swift-semantic-string fix details in the new changelog since the previous version's file was removed.
| @@ -1,9 +1,16 @@ | |||
| # 0.9.0 | |||
| # 0.10.0 | |||
There was a problem hiding this comment.
There is a version discrepancy between the changelog and the package manifest. Line 54 of this file states that MachOKit was bumped to 0.47.100, but the Package.swift manifest still references 0.46.1 (line 100) and 0.46.100 (line 189). Please ensure the manifest is updated to match the release notes or correct the changelog if the bump was not intended for this release.
|
|
||
| ## Bug Fixes | ||
|
|
||
| - **Demangling**: bumped `swift-demangling` to `0.2.0` to pick up a critical fix. `0.9.0` / `0.9.1` pinned `0.1.1`, which shipped the bug and must be avoided. |
There was a problem hiding this comment.
The PR description indicates that the 0.9.1 fixes are folded into these notes, but the specific details regarding the swift-semantic-string pin (which is critical for x86_64 universal builds) are missing. Since Changelogs/0.9.1.md is being removed, this information should be preserved here to maintain a complete history of fixes.
| - **Demangling**: bumped `swift-demangling` to `0.2.0` to pick up a critical fix. `0.9.0` / `0.9.1` pinned `0.1.1`, which shipped the bug and must be avoided. | |
| - **Demangling**: bumped `swift-demangling` to `0.2.0` to pick up a critical fix. `0.9.0` / `0.9.1` pinned `0.1.1`, which shipped the bug and must be avoided. | |
| - **Release workflow**: pinned `swift-semantic-string` to `0.1.1` to fix universal binary builds on x86_64 (restores macOS 10.15 deployment target for concurrency support). |
There was a problem hiding this comment.
Pull request overview
Prepares the 0.10.0 release, superseding 0.9.x, by bumping a critical demangling dependency and updating versioning/docs accordingly.
Changes:
- Bump
swift-demanglingdependency requirement to0.2.0. - Update README install snippet and CLI note to reference
0.10.0. - Update bundled development version placeholder and refresh release notes in
Changelogs/0.10.0.md(including supersede notice and updated Known Issues link).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Package.swift |
Updates swift-demangling dependency requirement to from: "0.2.0". |
README.md |
Updates SwiftPM install snippet and CLI behavior note to 0.10.0. |
Sources/swift-section/Version.swift |
Bumps local development placeholder version to 0.10.0-dev. |
Changelogs/0.9.1.md |
Removes the 0.9.1 changelog entry. |
Changelogs/0.10.0.md |
Renames/updates release notes for 0.10.0, adds supersede warning + dependency fix note, and updates Known Issues link tag. |
Comments suppressed due to low confidence (1)
Changelogs/0.10.0.md:4
- The warning banner says the 0.9.x tags were pinned below 0.2.0, "which contains a critical demangling bug". This reads as if 0.2.0 contains the bug, but later in the same changelog you correctly state that 0.2.0 contains the fix and 0.1.1 shipped the bug. Please reword this sentence to avoid implying 0.2.0 is the broken release (e.g., say the bug is fixed in 0.2.0 / present in 0.1.1).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
swift-demanglingdependency to0.2.0to pick up a critical demangling fix (the0.1.1pin used by0.9.0/0.9.1is known-broken).Changelogs/0.9.0.md→Changelogs/0.10.0.mdand add a supersede notice pointing users off0.9.x.Changelogs/0.9.1.md(the semantic-string release-pin patch is folded into the broader0.10.0notes).README.mdinstall snippet + CLI note to0.10.0.Sources/swift-section/Version.swiftplaceholder to0.10.0-dev.Test plan
swift package update— resolvesswift-demanglingto0.2.0swift build— succeeds (0 errors, 0 linker errors)0.10.0, release CI builds the universal binary and publishes the GitHub release usingChangelogs/0.10.0.md0.9.0/0.9.1releases (edit release notes with supersede banner, mark as prerelease)