Skip to content

Sleuth#11

Open
markmcdowall wants to merge 112 commits into
masterfrom
sleuth
Open

Sleuth#11
markmcdowall wants to merge 112 commits into
masterfrom
sleuth

Conversation

@markmcdowall

Copy link
Copy Markdown
Member

This is a new tools for the analysis of differential gene expression.

It has required changes to the original process_rnaseq pipeline for the packaging of the results as well as new pipelines and tools.

@rehamFatima rehamFatima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code.
Please find my humble review comments.

Comment thread docs/test_data/testData_Sleuth.rst Outdated
.. code-block:: none
:linenos:

# Extract the original reads from teh FASTQ files

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the* FASTQ

Comment thread process_sleuth.py Outdated

class process_sleuth(Workflow):
"""
Functions for processing Chip-Seq FastQ files. Files are the aligned,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then* aligned ?

Comment thread process_sleuth.py Outdated
metadata : dict
Input file meta data associated with their roles

kallisto_tar : str

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line duplicated ?

Comment thread scripts/install_sleuth.R Outdated
source("http://bioconductor.org/biocLite.R")
if(!require("rhdf5")) biocLite("rhdf5")
if(!require("devtools")) install.packages("devtools")
if(!require("sleuth")) devtools::install_github("pachterlab/sleuth") No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new line sign

"file_path": "tests/data/kallisto.run_info.json",
"file_path": "tests/data/kallisto.Human.ERR030872.tar.gz",
"data_type": "data_rna_seq",
"compressed": "null"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Q) . What exactly is the compressed tag for ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indicate if the file is compressed or not.

Comment thread tidy_data.sh Outdated
fi
done

# Added to remove the Sleuth results folder due to nexted structure

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neSted?

Comment thread tool/kallisto_quant.py Outdated
),
"run_info_file": Metadata(
"kallisto_tar_file": Metadata(
data_type="data_ranseq",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rna* ?

}
}
]
} No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No newline error sign

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as it is a JSON file

Comment thread tool/sleuth.py Outdated

class sleuthTool(Tool): # pylint: disable=invalid-name
"""
Tool for peak calling for iDamID-seq data

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( iDamID ? )

Comment thread tool/sleuth.py Outdated
def run(self, input_files, input_metadata, output_files):
"""
The main function to run Sleuth over a set of RNA-seq experiments
nalysed using Kallisto to identify differentially expressed genes.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

analysed

@markmcdowall

Copy link
Copy Markdown
Member Author

Awaiting confirmation about the method for passing the parameters to the RNA-seq pipeline and Sleuth before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants