Skip to content

Remove unused fiat module#162

Merged
grunch merged 1 commit intomainfrom
chore/remove-unused-fiat-module
Apr 15, 2026
Merged

Remove unused fiat module#162
grunch merged 1 commit intomainfrom
chore/remove-unused-fiat-module

Conversation

@grunch
Copy link
Copy Markdown
Member

@grunch grunch commented Apr 15, 2026

Summary by CodeRabbit

  • Refactor
    • Removed fiat currency handling functionality, including currency ticker validation and fiat value loading systems.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4396d25e-dee3-4155-b588-5edda07ac879

📥 Commits

Reviewing files that changed from the base of the PR and between ce07604 and d35e5ff.

📒 Files selected for processing (1)
  • src/fiat.rs
💤 Files with no reviewable changes (1)
  • src/fiat.rs

Walkthrough

The entire src/fiat.rs module has been removed, including exported type aliases (FiatNames, FiatList), a FiatNamesValue struct, and two public functions (check_currency_ticker() and load_fiat_values()) that provided fiat currency ticker validation and metadata loading capabilities.

Changes

Cohort / File(s) Summary
Fiat Module Removal
src/fiat.rs
Deleted entire module containing fiat currency type aliases, a FiatNamesValue struct, and functions for currency ticker validation and loading embedded JSON fiat metadata (1466 lines removed).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A fiat farewell, the module's gone away,
No more tickers checked or JSON to display,
Currencies cached were lovely, it's true,
But sometimes clean slates lead to clearer views!
✨ Hop along, codebase, to brighter horizons anew!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove unused fiat module' accurately and concisely summarizes the main change: deletion of the entire src/fiat.rs file and its exported functions and types.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-unused-fiat-module

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@grunch grunch merged commit a48bb66 into main Apr 15, 2026
6 checks passed
@grunch grunch deleted the chore/remove-unused-fiat-module branch April 15, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant