Animartrix plus: HUE shift, contrast & brightness boost

[softhack007]

• add contrast and brightness boost checkboxes
• add static HUE shift -> slider changes the main color (HUE)
• add dynamic HUE cycling -> time-based, slider for speed of change
• gamma correction moved into global UM settings
• toDo: decide if having two sliders (static HUE shift, HUE change speed) is better
• toDo: make HUE cycling audioreactive (slider)
• toDo: Screenshots

Breaking: the first checkbox was previously used for "correct gamma", which is now part of the global usermod settings. This means that gamma correction needs to be switched off in UM settings, instead of setting it with each effect.
Due to the "re-purposed" slider, old preset may start HUE cycling.

Animartix_hue_cycle_part2.mp4

Future idea: alternative to CHSV32-based HUE rotation

check if the matrix-based HUE rotation described here works, too: https://agatedragon.blog/2024/04/02/hue-shift-shader/ .

It looks like three matrices (3x3) are needed: convert color vector to YIQ format, rotate (I,Q) but leave Y untouched, and finally convert back to color with another matrix. All the three matrices can be pre-calculated per frame, and pre-multiplied (use matrix multiplication!) into a single combined "color shift" matrix. Then on pixel level, a simple vector x matrix multiplication should be enough.

Summary by CodeRabbit

• New Features

  • Hue cycling and static hue-shift controls for dynamic color movement.
  • Optional boosts for brightness and contrast plus an on/off gamma correction toggle.
  • New UI controls exposing Speed, HUE Change, cycle HUE, boost Brightness, boost Contrast.

• Refactor

  • Unified color-processing so hue shift, brightness, contrast, and gamma apply consistently.
  • Higher-precision hue handling for smoother color transitions and accurate color conversions.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• ✅ Review completed - (🔄 Check again to review again)

📝 Walkthrough

Walkthrough

Centralizes pixel color processing in ANIMartRIXMod (gamma, contrast, brightness, hue shift/cycling) and adds a new CHSV32 color utilities header with high-resolution hue and RGB/HSV conversion helpers.

Changes

Cohort / File(s)	Summary
ANIMartRIXMod color pipeline usermods/usermod_v2_animartrix/usermod_v2_animartrix.h	Adds centralized processColor(rgb) and static helpers enhanceContrast, enhanceBrightness, applyGamma24; introduces hueshift, public flags cycle_hue, boost_brightness, boost_contrast; routes pixel-setting through processColor; implements time/static hue shift and updates mode strings and initEffect mappings.
Color utilities wled00/colors.h	Adds CHSV32 (16-bit hue, 8-bit sat/val, 32-bit raw) with constructors and conversion to/from CHSV; provides hsv2rgb and rgb2hsv functions for high-resolution hue operations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐇 I nibble bits and shift the hue,
I boost the light, then smooth it too.
Sixteen-bit dawn, a finer sweep,
ANIMartRIX wakes pixels from sleep,
Hop—small changes make colors true.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 36.36% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title accurately describes the main changes: adding HUE shift (both static and dynamic cycling), contrast boost, and brightness boost to the Animartrix usermod.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch animartrix_plus

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}