Skip to content

Build setup: minimal fs_data + override example#343

Open
GraspGG wants to merge 4 commits intoMoonModules:mdevfrom
GraspGG:olaf/mdev
Open

Build setup: minimal fs_data + override example#343
GraspGG wants to merge 4 commits intoMoonModules:mdevfrom
GraspGG:olaf/mdev

Conversation

@GraspGG
Copy link

@GraspGG GraspGG commented Mar 1, 2026

Adds minimal fs_data JSON placeholders (no secrets) and an override example for local builds.

Summary by CodeRabbit

  • Chores

    • Added minimal placeholder configuration files to support local build customization and user-specific settings.
    • Included an example local build override to customize build environment and release naming.
  • Documentation

    • Added a README explaining how to use a local data directory for reduced filesystem payloads and reproducible local/CI builds.

@coderabbitai
Copy link

coderabbitai bot commented Mar 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9884ee7 and 095ed54.

📒 Files selected for processing (1)
  • fs_data/README.md
✅ Files skipped from review due to trivial changes (1)
  • fs_data/README.md

📝 Walkthrough

Walkthrough

Four new files were added: three empty JSON placeholders in fs_data/ (cfg.json, presets.json, wsec.json) and a PlatformIO override example plus README documenting local data_dir usage.

Changes

Cohort / File(s) Summary
Configuration Placeholders
fs_data/cfg.json, fs_data/presets.json, fs_data/wsec.json
Added empty JSON objects as placeholders for config, presets, and security data.
PlatformIO Override Example
platformio_override.ini.olaf.example
Added local PlatformIO override snippet setting default_envs = esp32_4MB_V4_M and build_flags including WLED_RELEASE_NAME="WLEDMM-OLAF".
fs_data Documentation
fs_data/README.md
Added README explaining use of fs_data as data_dir, recommended files, and usage with local PlatformIO overrides.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 I dug three jars — empty, neat,
A tiny override for builds to meet,
A README trail to mark the way,
Small hops of files to cheer the day! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: introducing minimal fs_data JSON files and a PlatformIO override example for local builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@softhack007
Copy link
Collaborator

@GraspGG what is fs_data used for? I've never seen the folder, maybe you can say a few words about the purpose?

@GraspGG
Copy link
Author

GraspGG commented Mar 2, 2026

@GraspGG what is fs_data used for? I've never seen the folder, maybe you can say a few words about the purpose?

fs_data is a local/minimal PlatformIO data_directory used to build/upload a small filesystem image (via buildfs/uploadfs).
I introduced it because the default WLED00/data content (pxmagic etc.) exceeded my ESP32 4MB FS partition during mkspiffs, causing an SPIFFS_write error: File system is full.
With fs_data I can keep only tiny config files (e.g. empty or template cfg.json, presets.json, optionally wsec.json without secrets) and still use the PR/build workflow without touching upstream platformio.ini.
Simplified: It’s basically a “minimal FS payload” folder for reproducible builds on limited flash/FS layouts.

Thank you for pointing me on that documentation gap!
I should have added a README to that folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants