bugfix: fix visual recv batch counter type

[shihaobai]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a subtle type bug where a counter variable, visual_recv_max_count, could inadvertently become a floating-point number. By explicitly casting its value to an integer after calculation, the change ensures the counter maintains its intended integer type, preventing potential runtime errors or unexpected behavior in the visual server's request handling logic.

Highlights

• Type Correction: The visual_recv_max_count variable, which controls the maximum number of received items, is now explicitly cast to an integer to prevent potential floating-point issues after calculation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• lightllm/server/visualserver/manager.py
  • Ensured self.visual_recv_max_count is always an integer after calculation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a TypeError by ensuring self.visual_recv_max_count is always an integer. The change is valid and addresses the bug. I have added one suggestion to improve code maintainability by replacing magic numbers with named constants.

[gemini-code-assist]

The values 1.3 and 256 are magic numbers. To improve readability and maintainability, consider defining them as named constants (e.g., VISUAL_RECV_MAX_COUNT_GROWTH_FACTOR and VISUAL_RECV_MAX_COUNT_LIMIT) at the class or module level. The value 64 used for initialization and reset of visual_recv_max_count on lines 185 and 202 could also be defined as a constant.