Add first-class extended agent card discovery API#28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fetchflow (validation, error mapping, parsing) while offering a dedicated API for the extended endpoint.Description
DiscoveryClient::FetchExtendedAgentCard(std::string_view)ininclude/a2a/client/discovery.hto expose the extended discovery flow.DiscoveryClient::FetchExtendedAgentCardandBuildExtendedDiscoveryUrlinsrc/client/discovery.cppthat construct the extended discovery endpoint as/.well-known/agent-card.json?view=extended, fetch, parse, and validate the returnedAgentCard.FetchExtendedAgentCardUsesExtendedQueryPathintests/unit/discovery_test.cppthat verifies the extended URL is used and that a valid response is parsed and validated.Testing
clang-format --dry-run --Werrorand normalized code with./scripts/run_clang_format.sh(passed)../scripts/verify_changes.shwhich performed CMake configure/build,ctest, andclang-tidy; the workflow completed and returned success.ctestduring verification and observed all tests passed (128/128 tests)../scripts/run_clang_tidy.sh buildas part of verification and observed it completed successfully.Codex Task