Skip to content
This repository was archived by the owner on Dec 31, 2025. It is now read-only.

Profile Editor & Profile Improvements#75

Draft
raymonable wants to merge 61 commits intomainfrom
profile-editor
Draft

Profile Editor & Profile Improvements#75
raymonable wants to merge 61 commits intomainfrom
profile-editor

Conversation

@raymonable
Copy link
Contributor

@raymonable raymonable commented May 7, 2025

Currently has partial functionality.

Profile picture uploading needs to be implemented.
Profile pictures are more complex as they will probably require JS.

Not sure how to implement it though, needs consulting.

Also, @nbitzz, please help me pretty it up when you get the time; the page looks incredibly dull without any user data imported but importing the user data would be basically impossible without reworking a significant chunk of the page (and would probably be better if we just move all of it into it's own Component, but this is something I would prefer for you to make the choice for)

image
image

VERY work in progress, functional though
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raymonable! 👋

Your private repo does not have access to Sourcery.

Please upgrade to continue using Sourcery ✨

@raymonable raymonable marked this pull request as draft May 7, 2025 23:51
@Jack5079
Copy link
Contributor

Jack5079 commented May 7, 2025

https://github.com/mollersuite/luau/blob/main/routes/script/%5Bid%3Duuid%5D.svelte ass edit mode
Probably needs a cancel button

@Jack5079
Copy link
Contributor

Jack5079 commented May 7, 2025

Never mind I'm stupid just read the translations

@raymonable
Copy link
Contributor Author

Never mind I'm stupid just read the translations

there's no cancel button :trollface:

@raymonable raymonable requested a review from nbitzz May 28, 2025 03:57
@raymonable
Copy link
Contributor Author

Page has been reworked.

image

@raymonable
Copy link
Contributor Author

@nbitzz URGENT: can you check how this works on a game-less profile

@raymonable raymonable changed the title Profile Editor Profile Editor & Profile Improvements Jun 26, 2025
Copy link
Collaborator

@korewaChino korewaChino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raymonable! 👋

Your private repo does not have access to Sourcery.

Please upgrade to continue using Sourcery ✨

@raymonable
Copy link
Contributor Author

@nbitzz Can this be merged soon?

THIS DOES NOT WORK ON PROD!!! REQUIRES CUSTOM BACKEND FUNCTIONALITY THAT HAS NOT BEEN IMPLEMENTED ON AQUADX MAIN BRANCH
THIS DOES NOT WORK ON PROD!!! REQUIRES CUSTOM BACKEND FUNCTIONALITY THAT HAS NOT BEEN IMPLEMENTED ON AQUADX MAIN BRANCH
@raymonable
Copy link
Contributor Author

nvm

@raymonable raymonable marked this pull request as draft August 1, 2025 03:59
@raymonable
Copy link
Contributor Author

raymonable commented Aug 6, 2025

OK, it's almost finished. I need @nbitzz to help me with adding a loading indicator when the profile is being updated and to make backgrounds work site-wide (I have no clue what would be the best way to approach this, sorry)

Oh, oops, forgot to mention, it doesn't undo the profile picture or background when you press cancel, it doesn't upload but it looks like it did when it didn't

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants