secp256k1: add explicit compressed/uncompressed pubkey serialisation#39
Merged
Conversation
smoyer64
previously approved these changes
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Is the deserialize going to auto-detect the format now (or experimentally probe for valid formats?)
MichaelMure
force-pushed
the
secp256k1-secpub
branch
from
a3bbd78 to
bd0d353
Compare
smoyer64
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: adds explicit serialization helpers and a small unit test without changing existing serialization behavior (
ToBytesremains compressed).Overview
Adds explicit
PublicKey.CompressedBytes()andPublicKey.UncompressedBytes()helpers (SEC1 33-byte and 65-byte encodings) and documents thatToBytes()is the compressed form.Extends tests with
TestPublicKeyFromBytesEncodingsto ensurePublicKeyFromBytescan round-trip both compressed and uncompressed encodings.Written by Cursor Bugbot for commit bd0d353. This will update automatically on new commits. Configure here.