feat(sdk): add BuildId newtype and implement remaining pending tests#313
Draft
feat(sdk): add BuildId newtype and implement remaining pending tests#313
Conversation
f11b332 to
0324e69
Compare
33ecd5c to
447c6d7
Compare
0324e69 to
cddb214
Compare
447c6d7 to
2a05c61
Compare
1e3c5f2 to
461ac0d
Compare
cde5776 to
9c75170
Compare
461ac0d to
3693805
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuildIdnewtype inTemporal.Common, updateInfofield andsetBuildIdAPI to use it instead of rawText