fix: add explicit UTF-8 encoding to read_text() calls (#776)#946
Open
mvalentsev wants to merge 1 commit intoMemPalace:developfrom
Open
fix: add explicit UTF-8 encoding to read_text() calls (#776)#946mvalentsev wants to merge 1 commit intoMemPalace:developfrom
mvalentsev wants to merge 1 commit intoMemPalace:developfrom
Conversation
On Windows with non-UTF-8 locale (e.g. GBK), Path.read_text() defaults to platform encoding, breaking onboarding tests and any source code that reads JSON/markdown with non-ASCII content. 5 files, 8 call sites fixed.
mvalentsev
requested review from
bensig,
igorls and
milla-jovovich
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Path.read_text()withoutencodingdefaults to platform encoding on Windows. On locales like GBK this breaks any file written as UTF-8.8 call sites fixed across 5 files:
Why explicit encoding, not PYTHONUTF8
Considered alternatives:
PYTHONUTF8=1in CI -- must be set before Python starts, so it can't go in conftest.py. Works for CI but doesn't fix local test runs on Windows. Also a global override of all I/O which can mask real encoding bugs.encoding="utf-8"per call -- PEP 597 recommendation. Works on all Python versions, all platforms, no env setup needed.Test plan
pytest tests/test_onboarding.py tests/test_instructions_cli.py -v-- 52 passed locally