fix(hooks): resolve Claude plugin hook runner cross-platform#942
fix(hooks): resolve Claude plugin hook runner cross-platform#942fatkobra wants to merge 4 commits intoMemPalace:developfrom
Conversation
|
Thanks for the pointer @mvalentsev . I checked #833, and it looks complementary rather than identical:
Issue #753’s current code example is the wrapper path ( If maintainers would prefer a single combined solution, I’m happy to close this and rework it on top of #833, but as written it looks like #942 fixes the plugin wrapper layer while #833 fixes the legacy save/precompact shell hooks. |
|
You're right, my mistake -- #833 targets hooks/ (legacy scripts) while this PR targets .claude-plugin/hooks/ (plugin wrappers). Different files, complementary fixes. Thanks for checking. |
|
btw, |
|
Thanks — agreed on both points.
However, I think it is better to keep the MCP config files ( |
What does this PR do?
Closes #753
Summary
.claude-plugin/hooks/mempal-stop-hook.sh.claude-plugin/hooks/mempal-precompact-hook.shmempalaceCLIpython3/pythonScope
This PR intentionally fixes the Claude plugin shell hook wrappers only.
It does not change
.claude-plugin/plugin.jsonor.claude-plugin/.mcp.json,which still need a separate supported mechanism for MCP command resolution.
How to test
Manual verification
python3: command not found{}with exit code 0 in a PATH containingpythonbut nopython3Validation
bash -n .claude-plugin/hooks/mempal-stop-hook.shbash -n .claude-plugin/hooks/mempal-precompact-hook.shruff format tests/test_claude_plugin_hook_wrappers.pyruff check tests/test_claude_plugin_hook_wrappers.pyruff format --check tests/test_claude_plugin_hook_wrappers.pypython -m pytest tests/test_claude_plugin_hook_wrappers.py -vpython -m pytest tests/test_hooks_cli.py tests/test_claude_plugin_hook_wrappers.py -vpython -m pytest tests/ -vChecklist
python -m pytest tests/ -v)ruff check .)