Replace PouchDB credentials provider with file-backed JSON store#514
Open
fiachra wants to merge 1 commit into
Open
Replace PouchDB credentials provider with file-backed JSON store#514fiachra wants to merge 1 commit into
fiachra wants to merge 1 commit into
Conversation
The transitive sqlite3@4.2.0 (pouchdb-adapter-node-websql -> websql -> sqlite3) no longer compiles against Node 22/24 V8 headers, breaking `npm install` on modern Node versions. Rewrites @medable/mdctl-credentials-provider-pouchdb as an encrypted-at-rest JSON store. Same exported class name, same constructor signature, same CredentialsProvider API; PouchDB and its native deps are dropped. better-sqlite3 is declared as an optionalDependency and used only to read legacy SQLite stores during a one-shot migration. The legacy file is renamed to <name>.legacy-<timestamp> after a successful migration and verified read-back; it is never deleted, and a rollback README is written alongside it. Bumps all workspace packages to 1.0.75-alpha.0 (lerna), and CI matrix to [18, 20, 22, 24]. Adds .nvmrc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqlite3@4.2.0 (transitive via pouchdb-adapter-node-websql -> websql) fails
to compile against Node 22/24 V8 headers, breaking
npm installforanyone on a modern Node.
What
with a small file-backed JSON store. Same exported class, same constructor
signature, same CredentialsProvider API.
(declared as optionalDependency, used only for migration). Legacy file
is renamed (never deleted) with a rollback README.
.nvmrc.Test plan
successfully decrypts all 14 credentials
npm installsucceeds on Node v24.14.0 with no native build failures