Oasis unet reconstruction#40
Open
ydu0117 wants to merge 6 commits into
Open
Conversation
MatthiasLen
requested changes
May 8, 2026
Owner
There was a problem hiding this comment.
Dear @ydu0117 , thank you for the PR. I have reviewed it.
- there was some functionality missing related to automated model download. In my latest commit I have added SHA256 certified automated download. This means certification will fail if the model weights are updated. This it intentional to fix model weight versions etc. ... Good news is , the user gets the model automatically and no manual dowloading from GCP is needed. please have a look at my changes.
- I could resolve a small merge conflict
- I have added some missing dependencies in the pyproject.toml.
Open point I kindly ask you to support:
It could you add OASIS to the FastMRI reconstruction example in the same "lightweight way" as the other reconstructors ? Important: In case the OASIS and FastMRI dataset convention differ I would suggest to move this is a small separate adaptor class . The example code , the reconstructor API should not be "blown-up". If you have questions, please, ping me in teams or tag me here. Thanks 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests