Skip to content

Oasis unet reconstruction#40

Open
ydu0117 wants to merge 6 commits into
mainfrom
oasis_unet_reconstruction
Open

Oasis unet reconstruction#40
ydu0117 wants to merge 6 commits into
mainfrom
oasis_unet_reconstruction

Conversation

@ydu0117
Copy link
Copy Markdown
Collaborator

@ydu0117 ydu0117 commented May 7, 2026

Summary

  • Add OASIS inference plotting example
  • Add OASIS U-Net checkpoint loading through the shared fastMRI U-Net module
  • Enable OASIS k-space distortions and document reconstruction_only download link

Tests

  • uv run pre-commit run --all-files
  • uv run pytest

@MatthiasLen MatthiasLen added enhancement New feature or request recon labels May 7, 2026
@MatthiasLen MatthiasLen self-requested a review May 8, 2026 07:38
@MatthiasLen MatthiasLen self-assigned this May 8, 2026
Copy link
Copy Markdown
Owner

@MatthiasLen MatthiasLen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @ydu0117 , thank you for the PR. I have reviewed it.

  • there was some functionality missing related to automated model download. In my latest commit I have added SHA256 certified automated download. This means certification will fail if the model weights are updated. This it intentional to fix model weight versions etc. ... Good news is , the user gets the model automatically and no manual dowloading from GCP is needed. please have a look at my changes.
  • I could resolve a small merge conflict
  • I have added some missing dependencies in the pyproject.toml.

Open point I kindly ask you to support:
It could you add OASIS to the FastMRI reconstruction example in the same "lightweight way" as the other reconstructors ? Important: In case the OASIS and FastMRI dataset convention differ I would suggest to move this is a small separate adaptor class . The example code , the reconstructor API should not be "blown-up". If you have questions, please, ping me in teams or tag me here. Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request recon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants