29 cartesian undersampling distortion#32
Merged
Conversation
MatthiasLen
added
enhancement
Collaborator
melanie-dohmen-bayer
left a comment
melanie-dohmen-bayer
left a comment
There was a problem hiding this comment.
Looks fine, if center_fraction is allowed to be 0.0, for respresenting FOV reduction and aliasing
There was a problem hiding this comment.
Pull request overview
Adds a new Cartesian k-space undersampling distortion to better simulate physically realistic MRI acquisition undersampling (binary line mask with optional ACS), and wires it into the project’s public API, tests, docs, and an example script.
Changes:
- Implement
CartesianUndersamplingdistortion with keep/center fraction controls and multiple sampling patterns (uniform random, variable density random, equispaced) plus mask caching. - Export the new distortion from
mri_recon.distortionsand document it in the README distortions table. - Extend distortion tests and update the FastMRI inference example to include new undersampling presets.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
mri_recon/distortions/undersampling.py |
Adds the new CartesianUndersampling distortion implementation, including mask generation and caching. |
mri_recon/distortions/__init__.py |
Exposes CartesianUndersampling from the distortions package. |
tests/test_distortions.py |
Adds validation, determinism, ACS preservation, masking behavior, caching, and adjointness tests for the new distortion. |
README.md |
Documents the new distortion in the distortions table. |
examples/fastmri_inference_plot.py |
Adds selectable undersampling distortion presets and adjusts the example’s algorithm list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29 . See issue for detailed description.