This repository was archived by the owner on Dec 25, 2019. It is now read-only.
Open
Conversation
Contributor
|
Ah shoot, sorry to miss this @sploiselle! Definitely ping if it takes me more than a day for me to respond, though I try to be faster than that. |
benesch
reviewed
Dec 18, 2019
| } | ||
| let mut peekable = chars_w_leading_zero.chars().peekable(); | ||
|
|
||
| self.tokenize_number(&mut peekable) |
Contributor
There was a problem hiding this comment.
Could be wrong—haven't actually tried—but I think this mishandles something like ..07. I'd recommend refactoring tokenize_number to take seen_decimal as a bool parameter, and then initialize s inside of tokenize_number to . if seen_decimal is true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library didn't parse
.123as a number; with this patch, it now does.