mcp: add developer endpoint instructions for ontology-guided queries#36069
mcp: add developer endpoint instructions for ontology-guided queries#36069bobbyiliev wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
450112d to
3c6146a
Compare
3c6146a to
51aa547
Compare
mtabebe
left a comment
There was a problem hiding this comment.
This is great! A few questions/comments
- I don't think we can actually merge now, because these tables don't exist. And if they do they will likely not have the mz_ name for now (as we aren't sure if we are going to use built in tables for now).
- If I have more detailed prompts, what is the best way to load that as context (https://github.com/MaterializeInc/materialize/pull/36051/changes#diff-a96642aa1a069c9e0c155c6169b5398b9d4a3c55205918c6ce17318b76439c96) That is is there a way to give the MCP server the MD files?
In the meantime, I'm going to cherry pick this change locally for testing!
Thanks for the fast turn around!!
|
Thanks @mtabebe good catches!
|
|
ah cool about the skill, in my hack here, I just included the file directly 🤣 5d7c5d0#diff-21bbf589585fdbbf4f4d53d77a3beb188699f8ca61c689658de2db260dd753ed |
mtabebe
left a comment
There was a problem hiding this comment.
LGTM, I think this is a good starting point and will be easy to iterate on.
In my commit I was a bit stronger with the language, since I was getting frustrated with Claude hallucination: 5d7c5d0#diff-21bbf589585fdbbf4f4d53d77a3beb188699f8ca61c689658de2db260dd753ed
But given we aren't going to merge right away, I'm happy to approve
|
Thanks @mtabebe! Sounds good to me! I'll wait for your signal before merging this 🙌 |
|
@bobbyiliev minor comment, it seems likely the tables will be of the form: mz_internal.mz_ontology_link_types once they go into the built ins. So: mz_internal.mz_ontology_link_types, mz_internal.mz_ontology_properties, mz_internal.mz_ontology_semantic_types, mz_internal.mz_ontology_entity_types |
As discussed here