Make sure to get the resource directory from the right clang compiler#978
Open
rherilier wants to merge 1 commit intoMaskRay:masterfrom
Open
Make sure to get the resource directory from the right clang compiler#978rherilier wants to merge 1 commit intoMaskRay:masterfrom
rherilier wants to merge 1 commit intoMaskRay:masterfrom
Conversation
Owner
|
I download prebuilt Clang packages on https://releases.llvm.org/download.html then set CMAKE_PREFIX_PATH to the root directory of the extracted tarball. ``Clang_EXECUTABLE` will respect that.
|
Author
|
Thanks, I did not expect any differences between Windows and UNICES builds... |
…ompiler The resource directory was always retrieved from the system's default clang compiler instead of the targeted one.
rherilier
force-pushed
the
fix-call-to-wrong-clang
branch
from
50d001c to
84b3c69
Compare
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
e403622 to
cfc7c02
Compare
MaskRay
force-pushed
the
master
branch
2 times, most recently
from
49cbf37 to
aca8280
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resource directory is always retrieved from the system's default clang compiler instead of the targeted one.
I notice it after removing clang from my system (which is an alias for clang-16) while keeping clang-19 installed.