MDEV-39118: test_if_hard_path crashes on recursively resolving $HOME#4943
Open
raghunandanbhat wants to merge 1 commit into10.11from
Open
MDEV-39118: test_if_hard_path crashes on recursively resolving $HOME#4943raghunandanbhat wants to merge 1 commit into10.11from
test_if_hard_path crashes on recursively resolving $HOME#4943raghunandanbhat wants to merge 1 commit into10.11from
Conversation
raghunandanbhat
force-pushed
the
10.11-mdev-39118
branch
from
b7cdebc to
2b195e1
Compare
Problem: When `$HOME` is set to `~/` (or any string starting with `~/`), the `home_dir` is initialized to that value. When `test_if_hard_path` is called on a path starting with `~/`, it replaces the `~/` prefix by recursively calling `test_if_hard_path(home_dir)` leading to infinite recursion and a crash. Fix: Add a check in `test_if_hard_path` to see if `home_dir` itself begins with `~/`. If it does, skip the recursive call to prevent the infinite loop.
raghunandanbhat
force-pushed
the
10.11-mdev-39118
branch
from
2b195e1 to
0343b0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes MDEV-39118
Problem:
When
$HOMEis set to~/(or any string starting with~/), thehome_diris initialized to that value. Whentest_if_hard_pathis called on a path starting with~/, it replaces the~/prefix by recursively callingtest_if_hard_path(home_dir)leading to infinite recursion and a crash.Fix:
Add a check in
test_if_hard_pathto see ifhome_diritself begins with~/. If it does, skip the recursive call to prevent the infinite loop.