Skip to content

MDEV-39290 mytop use invoking login as default user on Unix #4918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aquilamacedo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MDEV-39290 mytop use invoking login as default user on Unix #4918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions scripts/mytop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,11 @@ sub cmd_s;
sub cmd_S;
sub cmd_q;

## Default username, matching mysql/mariadb on Unix
my $default_db_user = $WIN
? 'root'
: ((getpwuid($<))[0] || $ENV{LOGNAME} || $ENV{USER} || 'root');

## Default Config Values

my %config = (
Expand Down Expand Up @@ -99,7 +104,7 @@ my %config = (
slow => 10, ## slow query time
socket => '',
sort => 1, ## default or reverse sort ("s")
user => 'root',
user => $default_db_user,
fullqueries => 0, ## shows untruncated queries
usercol_width => 8, ## User column width
dbcol_width => 9, ## DB column width
Expand Down Expand Up @@ -285,7 +290,7 @@ if (not ref $dbh)
Cannot connect to MariaDB/MySQL server. Please check the:

* database you specified "$config{db}" (default is "")
* username you specified "$config{user}" (default is "root")
* username you specified "$config{user}" (default is "$default_db_user")
* password you specified "$config{pass}" (default is "")
* hostname you specified "$config{host}" (default is "localhost")
* port you specified "$config{port}" (default is 3306)
Expand Down Expand Up @@ -2252,7 +2257,9 @@ have two dashes `--'. Short arguments only have one '-'.

=item B<-u> or B<--user> username

Username to use when logging in to the MariaDB server. Default: ``B<root>''.
Username to use when logging in to the MariaDB server. On Unix, the default
is your login name (same as the C<mysql>/C<mariadb> client). On Windows, the
default is ``B<root>''.

=item B<-p> or B<--pass> or B<--password> I<password>

Expand Down Expand Up @@ -2386,8 +2393,9 @@ command-line arguments are processed, so your command-line arguments
will override directives in the config file.


Here is a sample config file C<~/.mytop> which implements the defaults
described above.
Here is a sample config file C<~/.mytop>. Omit C<user> to keep the built-in
default (Unix login on non-Windows, same as C<mysql>/C<mariadb>), the line
below is only if you want to connect as C<root> explicitly.

user=root
pass=
Expand Down
Loading