CSS/design Improvements#51
Open
punkfairie wants to merge 6 commits intoLocal-Connectivity-Lab:mainfrom
Open
Conversation
The span hover rules were under .nav-link already, and <span> is inside .nav-link, so it makes more sense to nest it under .nav-link.
Hover effects are barely seen on mobile anyway, and it makes the mobile nav menu look weird.
Looks a little nicer.
Contributor
|
@kevinkace please approve and I will merge after approval, thanks! |
Collaborator
|
These are good updates! WRT the fullwidth nav on desktop - is that purely an aesthetic choice? I could make arguments for tighter spacing, but I don't have a strong opinion either way. Let's gather opinions at standup on Weds. |
Contributor
|
Kevin, or Marley - can one of you be able to screen share on Wed, so those attending can give input? Kevin - please keep the test doc steps updated, and if a branch is ready to test, I can test locally, but will need the dependencies set from start, as I've needed node 22 and other settings for other things, so my env is modified from last times I've checked site locally |
philion
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I've fixed up a few things with the CSS/design.