Skip to content

fetchReactionPacks optimization #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ljupcho-ll wants to merge 1 commit into
base: TNTSample
Choose a base branch
from
Open

fetchReactionPacks optimization #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions TF1Sample/ReactionBarViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,19 +80,25 @@ class ReactionViewController: UIViewController {
}

private func fetchReactionPacks(reactionPackIDs: [String]) {
let group = DispatchGroup()
for packID in reactionPackIDs {
self.sdk.reaction.getReactionPackInfo(reactionPackID: packID) { result in
group.enter()
self.sdk.reaction.getReactionPackInfo(reactionPackID: packID) { [weak self] result in
defer { group.leave() }
guard let self = self else { return }
switch result {
case .success(let reactionPack):
self.setupReactions(reactionPack: reactionPack)
self.fetchUserReactions()
case .failure(let error):
print("Error fetching reaction pack info: \(error)")
}
}
}
group.notify(queue: .main) { [weak self] in
self?.fetchUserReactions()
}
}

@objc private func reactionButtonTapped(_ sender: UITapGestureRecognizer!) {
if let reactionView = sender.view as? ReactionView {
UIAccessibility.post(notification: .layoutChanged, argument: reactionView)
Expand Down