fix(mcp): drop root .mcp.json; recommend alwaysLoad in desktop config examples#143
Merged
Merged
Conversation
… examples Remove the repo-root /.mcp.json added in PR #140 (issue #139). The Li+ MCP suite is in preview phase, and the assumed install path is manual install via Claude Desktop's claude_desktop_config.json — not Claude Code's project-scoped .mcp.json. Shipping a root .mcp.json caused duplicate / override friction for users who already register the server in their Desktop config. Surface the alwaysLoad: true recommendation on the actual install surface instead: both claude_desktop_config.json examples in mcp-server/README.md (basic + self-hosted Worker) now include the field, with a single short note about the Claude Code v2.1.121+ requirement (released 2026-04-28). Older clients silently ignore the field. preview phase 中の install 経路は Desktop 設定への手動登録のみを前提とし、 将来の distribution 段階で root .mcp.json を再導入する余地を残す reversible delete として扱う。 Closes #141 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
github-rag-mcp | d6fd8db | Apr 28 2026, 02:41 PM |
liplus-lin-lay
commented
Apr 28, 2026
Member
Author
liplus-lin-lay
left a comment
liplus-lin-lay
left a comment
There was a problem hiding this comment.
AI セルフレビュー (auto mode)
変更内容
.mcp.jsonを真の削除 (10 行 → 0 行、file removed)mcp-server/README.mdのclaude_desktop_config.json例 2 箇所 (basic + self-hosted Worker) に"alwaysLoad": trueを追記- 同 README に Claude Code v2.1.121+ 要件と旧 client の field 無視に関する短い note を 1 箇所のみ追加
リスク評価
- 影響範囲: 設定 / docs のみ。ランタイムコードや Worker・migration には触れていない (CI / test / Workers Builds の 3 check すべて pass)
- 可逆性: 高。
.mcp.jsonの再導入は将来 distribution phase で git revert 可能 (PR #140 の reversible delete として扱う) - 後方互換性:
alwaysLoadを認識しない旧 Claude Code / Claude Desktop は field を無視するだけ。破壊的変更なし - scope creep: README / installation 系 docs を grep で確認したところ、root
README.md/README.ja.md/docs/installation*.mdにはclaude_desktop_configsnippet が存在しないことを確認済。version note の汚染は最小
判定
patch / config + docs only / 低リスク → auto mode の self-review pass 基準を満たす。マージへ進む。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/.mcp.jsonを削除する。Li+ MCP 群は preview 運用中で、現在の想定 install 経路は Claude Desktop のclaude_desktop_config.jsonへの手動登録のみ。Claude Code 専用 scope の root.mcp.jsonは重複 / override の混乱要因となるため反転させる (将来 distribution 段階で再導入し得る reversible delete)。alwaysLoad: trueの推奨先を実際の install 経路 =mcp-server/README.mdのclaude_desktop_config.json例 (basic + self-hosted Worker の 2 箇所) に移す。Claude Code v2.1.121+ (2026-04-28 release) で field が認識される旨の短い note を 1 箇所だけ添える。alwaysLoadを解釈しない旧 client は field を無視するだけなので後方互換性は維持される。Test plan
git diff --statで.mcp.jsonの真の削除 (file removed) とmcp-server/README.mdの編集のみが含まれることを確認claude_desktop_config.jsonsnippet 2 箇所 (basic + self-hosted) の双方に"alwaysLoad": trueが入っていることREADME.md/README.ja.md/docs/installation*.mdにはclaude_desktop_configsnippet が存在せず、不要な version note 汚染を起こしていないことCloses #141
Refs PR #140 (alwaysLoad 初版、本 PR で修正対象).