Skip to content

feat(plugin-fees): add APPLICATION_NAME, MULTI_TENANT_TIMEOUT, MULTI_TENANT_CACHE_TTL_SEC#1249

Merged
jeffersonrodrigues92 merged 1 commit intodevelopfrom
feat/plugin-fees-missing-envs
Apr 17, 2026
Merged

feat(plugin-fees): add APPLICATION_NAME, MULTI_TENANT_TIMEOUT, MULTI_TENANT_CACHE_TTL_SEC#1249
jeffersonrodrigues92 merged 1 commit intodevelopfrom
feat/plugin-fees-missing-envs

Conversation

@gandalf-at-lerian
Copy link
Copy Markdown
Contributor

What

Add three missing env vars to the plugin-fees configmap template + values.yaml:

Variable Default Purpose
APPLICATION_NAME plugin-fees Service identification for logs/tracing
MULTI_TENANT_TIMEOUT 30 HTTP client timeout (seconds) for tenant-manager requests
MULTI_TENANT_CACHE_TTL_SEC 120 TTL (seconds) for local tenant config cache (0 = disabled)

Found by comparing the chart against the app's .env reference.

Requested by: @JeffersonGR

…TENANT_CACHE_TTL_SEC

- APPLICATION_NAME: service identification for logs/tracing (default: plugin-fees)
- MULTI_TENANT_TIMEOUT: HTTP client timeout for tenant-manager (default: 30s)
- MULTI_TENANT_CACHE_TTL_SEC: local tenant config cache TTL (default: 120s)

Requested-by: @JeffersonGR
@gandalf-at-lerian gandalf-at-lerian requested a review from a team as a code owner April 17, 2026 21:31
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

The pull request adds three new environment variable configurations to the plugin-fees Helm chart: APPLICATION_NAME, MULTI_TENANT_TIMEOUT, and MULTI_TENANT_CACHE_TTL_SEC. These are defined in the Helm values file and rendered into the ConfigMap template, with the multi-tenant variables conditionally included based on configuration.

Changes

Cohort / File(s) Summary
Helm Configuration
charts/plugin-fees/templates/fees/configmap.yaml, charts/plugin-fees/values.yaml
Added three new environment variables to the plugin-fees chart: APPLICATION_NAME (default "plugin-fees") always included, plus MULTI_TENANT_TIMEOUT (default "30") and MULTI_TENANT_CACHE_TTL_SEC (default "120") conditionally rendered when multi-tenant mode is enabled.

Comment @coderabbitai help to get the list of available commands and usage tips.

@gandalf-at-lerian gandalf-at-lerian changed the base branch from main to develop April 17, 2026 21:32
@jeffersonrodrigues92 jeffersonrodrigues92 merged commit 9ef101d into develop Apr 17, 2026
3 of 4 checks passed
@jeffersonrodrigues92 jeffersonrodrigues92 deleted the feat/plugin-fees-missing-envs branch April 17, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants