Spend reinstated utxos when disconnecting a failed withdrawal bundle#84
Open
1440000bytes wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disconnect_withdrawal_bundle_failedhas an inverted check on the utxo delete:deletereturnstruewhen it actually removes an entry. When a known withdrawal bundle fails,connect_withdrawal_bundle_failedreinstates its utxos as spendable. So on disconnect the utxo is present,deletereturnstrueand the function errors withNoUtxoin the normal case.The result is that a reorg disconnecting a block that carries a
Failedevent for a known bundle always fails, leaving the node unable to follow the better mainchain branch. Every other delete check in the file is correct.Fix
Negate the condition so it errors only when the utxo is unexpectedly absent and spends it back into
stxosotherwise.Test
Added a unit test that reproduces the post-failure state (known bundle with its utxo reinstated), disconnects the failure and asserts the utxo is re-spent. It fails on the old code with the
NoUtxoerror and passes with the fix.