Allow registering multiple InvoicedItemsProcessingService impls

[labkey-adam]

Rationale

https://github.com/LabKey/kanban/issues/1577

We need to allow multiple modules to register a InvoicedItemsProcessingService impl. Provide a module at registration time and a container at retrieval time. Determine the impl to return based on active modules in the container.

Related Pull Requests

• Allow registering multiple InvoicedItemsProcessingService impls wnprc-modules#917
• https://github.com/LabKey/tnprcEHRModules/pull/248

[labkey-martyp]

Not sure if you were ready for code review on this. We'll need register calls then in the client repos?

[labkey-martyp]

I think we'll want to use EHR_BillingManager.get().getBillingContainer(getJob().getContainer());

[labkey-adam]

I think we'll want to use EHR_BillingManager.get().getBillingContainer(getJob().getContainer());

Okay, I'll make that change. Not needed in EHR_BillingController.java?

Does relying on the registration module being active in the billing container make sense to you? IMO, this is more reliable than using folder type (which the old comment had suggested).

[labkey-martyp]

Yeah probably should use the billing container as described above in the controller too. I don't think it will matter on a production server, but will probably matter on our test servers.

I think using the active modules in that container makes sense for production and test. Production will probably set that module property site wide, but tests will need to set it at the container level.

[labkey-adam]

Then I should probably just move the EHR_BillingManager.get().getBillingContainer() call into get()

[labkey-adam]

...except that the interface can't see the manager. So never mind.

[labkey-adam]

Not sure if you were ready for code review on this. We'll need register calls then in the client repos?

Yes, this PR references PRs in WNPRC and TNPRC that adjust registration. I've assigned you as reviewer to those.