Chore/portfolio polish#1
Merged
Merged
Conversation
The AI-assisted SDET kit (15 skills, 3 agents, 9 commands, hooks), CLAUDE.md, and most of docs/ were gitignored and invisible to anyone cloning the repo. Rewrite .gitignore to commit them as the centerpiece of the showcase; keep only .claude/settings.local.json (personal perms) and build artifacts ignored. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Remove installer scripts (init.sh, apply-kit.sh) that bootstrapped OTHER
repos — irrelevant clutter in a focused test suite.
- Move the active validators to tools/ and wire them in for real: new
'npm run validate' + 'make validate', and the pre-commit hook now runs
tools/validate-layout.sh + tools/lint-ui-spec.ts. The 'mechanically
enforced architecture' claim is now actually true and demonstrable.
- Rewrite tools/README.md to describe THIS repo's gates (was a greenfield
installer doc); rebrand tools/verify.sh off the greenfield framing.
- Delete empty placeholder dirs tests/{api,components,data}; trim
tests-config.json and tsconfig paths to the five real layers.
- Drop dead npm scripts (test:api, spec:gen/lint/sync) that pointed at a
nonexistent OpenAPI spec / api project; name the package after the repo.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…in CI - Delete build.yml (standalone Sonar) and playwright.yml (basic test run); both were redundant with tests.yml, which already runs the cross-browser matrix AND a Sonar job that waits for tests and feeds JUnit results. - Add 'npm run validate' + 'npm run format:check' to the CI lint step so the layered-architecture gates run on every push/PR (matches tools/README). Local smoke run against the live third-party sites is flaky by nature (SPA hydration timing); CI is the authoritative signal. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ixme The @ru crypto-gateway placeholder is an intentionally-unimplemented gap (the gateway isn't exposed upstream — see docs/ux-findings.md), not a missing assertion. Document the intent and disable the rule for that line so the lint gate is genuinely clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- README: new 'AI-assisted SDET workflow' section showcasing the committed .claude kit (15 skills, 3 subagents, 9 commands, hooks) with a mermaid /test-new pipeline diagram; mermaid layered-architecture diagram. - Fix every stale reference from the reorg: scripts/ -> tools/, the 5 real layers (drop components/api/clients/generated/data), removed tsconfig aliases, the SYNTHETIC_EMAIL_DOMAIN env note, the typecheck-only PostToolUse hook, the real pre-commit chain, and the single tests.yml CI. - Add honest framing: CI is the authoritative green signal; local runs against live third-party sites are flaky by nature. - New docs/ARCHITECTURE.md (layer diagram, boundary-rule table, kit pipeline) and CONTRIBUTING.md (how to add a test, gates, conventional commits, troubleshooting). - CLAUDE.md: correct the stack (black-box, no OpenAPI), layer graph, and hook description; drop the dead --project=api run line. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…nv loader
_seed.ts read process.env.{SEED,SYNTHETIC_EMAIL_DOMAIN} inline, contradicting
the repo's own hard rule ('No process.env.X inline. Use tests/infra/env.ts').
Add SYNTHETIC_EMAIL_DOMAIN to the zod schema and source both from env. Defaults
are unchanged (SEED=1234, yopmail.com) so factory determinism is identical.
Reconcile the README/CONTRIBUTING notes accordingly.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… template Independent review (Reality Checker) findings: - BLOCKER: delete the stale .github/tests.yml — a second 'tests' workflow in the wrong directory (ignored by GitHub) referencing phantom env vars (BASE_URL/API_BASE_URL/TEST_USER_*). It made the 'single CI workflow' claim false and read as scattered/unfinished. - MAJOR: README LOC benchmark was 1269; actual is 1073. Correct it. - MINOR: note that the OpenAPI dev-deps stay only to keep the .claude kit's contract skills runnable; add SYNTHETIC_EMAIL_DOMAIN to .env.example. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…cated Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Kseolis
added a commit
that referenced
this pull request
Jun 9, 2026
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.