KindleHIDPassthrough: install KOReader plugin when KOReader is present#20
Merged
Merged
Conversation
The kindle-hid-passthrough release tarball now ships a koreader-plugin/ directory. When /mnt/us/koreader/plugins/ exists, copy koreader-plugin/hidpassthrough.koplugin/ into it so users get the in-KOReader manager (scan / pair / connect / disconnect / logs / cache) without an extra install step. Skipped silently when KOReader isn't installed. uninstall.sh removes the plugin directory to mirror install behavior. Signed-off-by: Lucas Zampieri <lcasmz54@gmail.com>
Contributor
Author
|
Also @penguins184 let me know if there's anything I need to cleanup on this file, or something I should be doing differently |
Contributor
|
mm usually we don't do koplugins but this seems reasonable |
Contributor
|
@zampierilucas oh yeah was the usr/bin thing sorted out in the project architecture? I didn't do much about it myself because it didn't fail too much but I didn't want to change any paths the project relies on |
Contributor
|
LGTM, though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The kindle-hid-passthrough now ships a
koreader-plugin/directory as of v3.4.0. When/mnt/us/koreader/plugins/exists, copykoreader-plugin/hidpassthrough.koplugin/into it so users get the in-KOReader manager (scan / pair / connect / disconnect / logs / cache) without an extra install step. Skipped silently when KOReader isn't installed.uninstall.shmirrors the install: removes the plugin directory.