[FIX] Fix for iceberg's tooltips#644
[FIX] Fix for iceberg's tooltips#644kallmetony wants to merge 1 commit intoKiltMC:version/1.20.1from
Conversation
|
from #641 |
| private List<ClientTooltipComponent> kilt$gatherForgeTooltips(List<ClientTooltipComponent> original, @Local(argsOnly = true) List<Component> lines, @Local(argsOnly = true) Optional<TooltipComponent> visualTooltipComponent, @Local(argsOnly = true, ordinal = 0) int mouseX, @Local(argsOnly = true) Font font) { | ||
| // Iceberg handles tooltip gathering and wrapping itself, so we should not interfere with it. | ||
| // Otherwise, we get duplicate tooltips when text wrapping is applied. | ||
| if (kilt$isIcebergLoaded) { |
There was a problem hiding this comment.
This feels unsafe, are we sure this doesn't affect other Forge mods?
There was a problem hiding this comment.
well, I tested IAF and Minecolonies (with its deps) and everything works great
anyway, this only works in environments with Iceberg, and playing with Iceberg is pretty annoying, so users will end up uninstalling it along with any other mods that depend on it
There was a problem hiding this comment.
Look into other mods, specifically those that use the RenderTooltipEvent.GatherComponents event. Use the GitHub search to find mods that use this event themselves and make sure this code works as expected there.
There was a problem hiding this comment.
sure, will do that on weekends. for now I can approve that it works in a modpack with 418 mods and 4 mods that do something with tooltips:
There was a problem hiding this comment.
sorry, I was extremely busy for past few weeks and only got free time now. yep, this looks good for me
BluSpring
added
version: 1.20.1
3 participants
No description provided.