Merged
Conversation
Closed
09b2d2f to
886fe05
Compare
bruno-at-orange
commented
Feb 19, 2026
It fails with the errors:
- hook id: pyrefly
- exit code: 1
INFO Found `/Users/bruno/dvpt/khisto-python/pyproject.toml` marking project root, checking root directory with default configuration
ERROR Cannot set item in `dict[str | Any, list[float]]` [unsupported-operation]
--> src/khisto/core/cli_adapter.py:141:27
|
141 | result[col] = np.array([float(row[col]) for row in rows], dtype=np.float64)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
Argument `ndarray[tuple[Any, ...], dtype[float64]]` is not assignable to parameter `value` with type `list[float]` in function `dict.__setitem__`
ERROR Cannot set item in `dict[str | Any, list[float]]` [unsupported-operation]
--> src/khisto/core/cli_adapter.py:143:27
|
143 | result[col] = np.array([int(row[col]) for row in rows], dtype=np.int64)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
Argument `ndarray[tuple[Any, ...], dtype[signedinteger[_64Bit]]]` is not assignable to parameter `value` with type `list[float]` in function `dict.__setitem__`
ERROR Cannot set item in `dict[str | Any, list[float]]` [unsupported-operation]
--> src/khisto/core/cli_adapter.py:146:27
|
146 | result[col] = np.array([row[col] for row in rows], dtype=object)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
Argument `ndarray[tuple[Any, ...], dtype[Any]]` is not assignable to parameter `value` with type `list[float]` in function `dict.__setitem__`
ERROR Returned type `dict[str | Any, list[float]]` is not assignable to declared return type `dict[str, ndarray[tuple[Any, ...], dtype[Any]]]` [bad-return]
--> src/khisto/core/cli_adapter.py:148:12
|
148 | return result
| ^^^^^^
|
INFO 4 errors
886fe05 to
7031528
Compare
popescu-v
reviewed
Feb 20, 2026
popescu-v
reviewed
Feb 20, 2026
popescu-v
reviewed
Feb 20, 2026
popescu-v
reviewed
Feb 20, 2026
popescu-v
reviewed
Feb 20, 2026
popescu-v
reviewed
Feb 20, 2026
popescu-v
reviewed
Feb 20, 2026
popescu-v
requested changes
Feb 20, 2026
popescu-v
left a comment
There was a problem hiding this comment.
Several comments (most of them just questions).
- We use scikit-build-core, a build backend for Python that uses CMake - Khiops sources are download with the fetch mechanism of CMake - The version of khiops is specify in pyproject.toml CMake extract the version from the file pyproject.toml The version is specified in the "tool.khiops" section as "khiops-version = "x.y.z""
7031528 to
030e1d1
Compare
030e1d1 to
3bcd0ce
Compare
fc1f340 to
baa761e
Compare
d702c4d to
6747f5e
Compare
popescu-v
reviewed
Feb 25, 2026
4c0150a to
42c5308
Compare
c831309 to
503595a
Compare
popescu-v
reviewed
Feb 26, 2026
c36a015 to
d23559b
Compare
popescu-v
reviewed
Feb 26, 2026
popescu-v
reviewed
Feb 26, 2026
popescu-v
left a comment
There was a problem hiding this comment.
Just two pending questions (see the comments).
d23559b to
1ef71d7
Compare
1f14c38 to
529e254
Compare
popescu-v
reviewed
Feb 27, 2026
popescu-v
reviewed
Feb 27, 2026
| - name: Test built wheel | ||
| run: | | ||
| pip install --find-links=wheelhouse khisto | ||
| pip install pytest>=8.3 pytest-cov>=6 pytest-xdist>=3.6 pytest-sugar>=1.0 |
There was a problem hiding this comment.
I'd put these test dependencies into a test-requirements.txt file, then just do pip install -r test-requirements.txt.
529e254 to
7005f70
Compare
popescu-v
reviewed
Feb 27, 2026
popescu-v
reviewed
Feb 27, 2026
popescu-v
reviewed
Feb 27, 2026
popescu-v
reviewed
Feb 27, 2026
7005f70 to
ddf8fc6
Compare
popescu-v
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pip packaging with cmake
CMake extract the version from the file pyproject.toml
The version is specified in the "tool.khiops" section as "khiops-version = "x.y.z""
Add copyright in headers of source files: close #4