Fix incorrect Display formatting of ValidationError params#391
Open
mscofield0 wants to merge 4 commits intoKeats:masterfrom
Open
Fix incorrect Display formatting of ValidationError params#391mscofield0 wants to merge 4 commits intoKeats:masterfrom
mscofield0 wants to merge 4 commits intoKeats:masterfrom
Conversation
Owner
|
Can you add a test for it? |
Author
|
Just bumping since tests were added |
Th3Link
reviewed
Apr 14, 2026
Th3Link
suggested changes
Apr 14, 2026
Contributor
Th3Link
left a comment
Th3Link
left a comment
There was a problem hiding this comment.
Reviewed, code wise its fine for me, the git commit messages needs improvement though
Co-authored-by: Marc-Hendric Lühr <marc@luehr.dev>
Author
I would advise just to modify the squash commit info |
Th3Link
approved these changes
Apr 14, 2026
Th3Link
reviewed
Apr 14, 2026
Co-authored-by: Marc-Hendric Lühr <marc@luehr.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Printing a validation error should not yield
serde_jsonartifacts in its output.Fixes #383