Purge sort depending functions in favor of parametric functions#3773
Purge sort depending functions in favor of parametric functions#3773
Conversation
8256cc5 to
46212b5
Compare
It is a constant, not a SortDependingFunction.
This branch is not yet based on Java Parser. I thought, JP would take a bit longer than this PR. |
|
Delayed until #3120 is merged and invariants are changed from |
|
Per the KeY meeting: This PR is truly ready. Eventual syntax improvements are left for future PR (but should be discussed soon!) |
WolframPfeifer
left a comment
There was a problem hiding this comment.
I reviewed the code and it looks mostly fine, except for a few minor complaints (mostly about comments).
However, when trying to test the PR the GUI, already at start of KeY I get the following exception (even when removing the .key directory):
[16:35:05.483] ERROR XMLResources - Cannot not load help messages in info viewjava.util.InvalidPropertiesFormatException: jdk.internal.org.xml.sax.SAXParseException;
at java.base/jdk.internal.util.xml.PropertiesDefaultHandler.load(PropertiesDefaultHandler.java:85)
at java.base/java.util.Properties.loadFromXML(Properties.java:1003)
at de.uka.ilkd.key.util.XMLResources.getResource(XMLResources.java:58)
at de.uka.ilkd.key.util.XMLResources.<init>(XMLResources.java:36)
at de.uka.ilkd.key.gui.InfoView.<init>(InfoView.java:55)
at de.uka.ilkd.key.gui.InfoView.<init>(InfoView.java:149)
at de.uka.ilkd.key.gui.MainWindow.<init>(MainWindow.java:329)
at de.uka.ilkd.key.gui.MainWindow.getInstance(MainWindow.java:417)
I am not sure if the reason lies really in the PR, also KeY does not crash.
Apart from that and the minor comments, it seems to work fine.
Intended Change
Replace all sort depending functions from KeY and replace them with parametric functions, e.g., int::select -> select<[int]>.
This PR does not affect behavior. In particular, sequences are not (yet) made parametric and the grammar is not really modified.
SortDependingFunctionis removed.Plan
java.lang.Object::<created>Type of pull request
Ensuring quality
.github/workflows/tests.ymlAdditional information and contact(s)
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.