fix: broker sends error response instead of dropping connection#133
Merged
kamir merged 1 commit intoKafScale:mainfrom Mar 9, 2026
Merged
fix: broker sends error response instead of dropping connection#133kamir merged 1 commit intoKafScale:mainfrom
kamir merged 1 commit intoKafScale:mainfrom
Conversation
…ndler errors Previously, when a handler returned an error (e.g., unsupported Fetch version), the broker closed the TCP connection causing clients to see EOF. Now the broker constructs a minimal Kafka error response via kmsg.ResponseForKey and keeps the connection alive. Also removes the Fetch v11 minimum version check — kmsg handles all versions natively, so the broker can serve Fetch v0+ requests. This fixes "fetching message: EOF" errors seen with clients like segmentio/kafka-go or franz-go. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleConnectionto close the connection — clients saw EOF. Now the broker constructs a minimal Kafka error response viakmsg.ResponseForKeyand keeps the connection alive.Changed files
pkg/broker/server.gohandleConnectionsends error response +continueinstead ofreturn; addsbuildErrorResponsehelperpkg/broker/server_test.goTestServerHandleConnection_HandlerErrorverifies error response is sent instead of connection closecmd/broker/main.goAPIVersion < 11guard inhandleFetchTest plan
go test ./pkg/broker/passes — updated test verifies error response is sentgo test ./cmd/broker/passesgo test ./...passes — no regressions🤖 Generated with Claude Code